Mohammad/mbe ecdsa #54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alextse-bg
force-pushed
the
mohammad/mbe-ecdsa
branch
2 times, most recently
from
53f311b to
c4d4c6b
Compare
alextse-bg
force-pushed
the
mohammad/mbe-ecdsa
branch
5 times, most recently
from
7f3f777 to
a658fc7
Compare
pranavjain97
previously approved these changes
Jul 7, 2025
Contributor
pranavjain97
left a comment
pranavjain97
left a comment
There was a problem hiding this comment.
Non-blocking to test; but please do in a follow-up.
| @@ -0,0 +1,72 @@ | |||
| import { DklsComms, DklsDkg, DklsTypes } from '@bitgo-beta/sdk-lib-mpc'; | |||
Contributor
There was a problem hiding this comment.
Rename all these files to ecdsaMPCv2...
| /** | ||
| * Initialize MPCv2 key generation | ||
| */ | ||
| async initMpcV2(params: { source: 'user' | 'backup' }): Promise<MpcV2InitializeResponseType> { |
Contributor
There was a problem hiding this comment.
Suggested change
| async initMpcV2(params: { source: 'user' | 'backup' }): Promise<MpcV2InitializeResponseType> { | |
| async initEcdsaMpcV2KeyGen(params: { source: 'user' | 'backup' }): Promise<MpcV2InitializeResponseType> { |
| /** | ||
| * Execute a round in the MPCv2 protocol | ||
| */ | ||
| async mpcV2Round(params: { |
Contributor
There was a problem hiding this comment.
Suggested change
| async mpcV2Round(params: { | |
| async roundEcdsaMPCv2KeyGen(params: { |
| /** | ||
| * Finalize MPCv2 key generation | ||
| */ | ||
| async mpcV2Finalize(params: { |
Contributor
There was a problem hiding this comment.
Suggested change
| async mpcV2Finalize(params: { | |
| async finalizeEcdsaMPCv2KeyGen(params: { |
| }; | ||
|
|
||
| return { ...result, wallet: result.wallet.toJSON() }; | ||
| } else { |
Contributor
There was a problem hiding this comment.
Please move eddsa and mpcv2 key generation orchestration to seperate helper files. Add them to ecdsa.ts / eddsa.ts
mohammadalfaiyazbitgo
force-pushed
the
mohammad/mbe-ecdsa
branch
from
a658fc7 to
a7ef80f
Compare
mohammadalfaiyazbitgo
force-pushed
the
mohammad/mbe-ecdsa
branch
from
a7ef80f to
3c86a09
Compare
pranavjain97
approved these changes
Jul 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.